Added the replica count API change to Shared Image Gallery swagger file.#3757
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
| "type": "string", | ||
| "description": "The name of the region." | ||
| }, | ||
| "regionalReplicaCount": { |
There was a problem hiding this comment.
If the name of the region is called name, why the replica count still has the region as the property's prefix? Why not just replicaCount?
There was a problem hiding this comment.
Yes. Initially, we call it "replicaCount", the same as you suggested. Then we got some feedback from Kay Singh that it might be clearer to use "regionalReplicaCount". So we use this.
| "regionalReplicaCount": { | ||
| "type": "integer", | ||
| "format": "int32", | ||
| "description": "This is the number of source blob copies in this specific region." |
There was a problem hiding this comment.
source blob in the source region, or in the target region? Or target blob? Please consider revising the statement to make it clearer.
There was a problem hiding this comment.
So it is the copies of the source blob in the target regions. Will this be better "This is the number of copies of the source blobs in this target region."?
There was a problem hiding this comment.
@vanbasten2323 what exactly is the "number of copies of the source blobs mean"?
There was a problem hiding this comment.
@singhkays, the original mail communicates the new name would be scaleTier, so i am bit confused now. Can you guys offer some explanation, so i can communicate better to CLI users.
There was a problem hiding this comment.
Also, what is the service end default value for this?
|
LGTM, with some minor comments. |
|
Can one of the admins verify this patch? |
7 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger